Skip to content
This repository has been archived by the owner on May 11, 2024. It is now read-only.

refactor(flag): make flag in help more readable #392

Closed
wants to merge 17 commits into from
Closed

Conversation

alexshliu
Copy link
Contributor

@alexshliu alexshliu commented Sep 18, 2023

  1. use cli.StringSliceFlag to simplify code.
  2. use cli placeholder to make help info more readable. like following:
image

@alexshliu alexshliu marked this pull request as ready for review September 20, 2023 13:21
@alexshliu alexshliu enabled auto-merge (squash) September 21, 2023 12:55
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #392 (85adcd1) into main (bdca930) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #392   +/-   ##
=======================================
  Coverage   50.44%   50.44%           
=======================================
  Files          39       39           
  Lines        5000     5000           
=======================================
  Hits         2522     2522           
  Misses       2223     2223           
  Partials      255      255           
Files Coverage Δ
proposer/config.go 93.40% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

cmd/flags/driver.go Outdated Show resolved Hide resolved
cmd/flags/proposer.go Outdated Show resolved Hide resolved
proposer/config.go Show resolved Hide resolved
@davidtaikocha
Copy link
Member

Close this due to there will be lots of flags changes in #414 , these changes will also be migrated to that PR later on.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants